[Feature] - Add Submit API #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dtroupe-plaid
commented
Jun 13, 2024
•
dtroupe-plaid
commented
- Update Android SDK to 4.5.0.
- Update iOS SDK to 5.6.0.
- Add submit API.
dtroupe-plaid
requested review from
melissaosullivan
and removed request for
melissaosullivan
dtroupe-plaid
commented
Jun 26, 2024
| @@ -63,7 +63,7 @@ android { | |||
| compileSdkVersion 31 | |||
|
|
|||
| defaultConfig { | |||
| minSdkVersion rootProject.ext.safeExtGet("minSdkVersion", 21) | |||
| minSdkVersion rootProject.ext.has("minSdkVersion") ? rootProject.ext.minSdkVersion : 21 | |||
There was a problem hiding this comment.
This was changed in this PR, but it was causing compile errors for me so I modified it.
dtroupe-plaid
commented
Jun 26, 2024
| @@ -97,6 +100,18 @@ export function PlaidLinkScreen() { | |||
| }}> | |||
| <Text style={styles.button}>Open Link</Text> | |||
| </TouchableOpacity> | |||
| <TouchableOpacity | |||
There was a problem hiding this comment.
I left this here so testing would be easier. I'll remove after review.
|
@melissaosullivan @wkiefer there are some changes in this PR to make testing easier (package.lock etc). I will clean that up after review 😄 You should be able to test doing the following: cd example
npm run start
npm run androidcd example/ios
bundle install
pod install
cd ../
npm run start
npm run ios |
wkiefer
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.